coderfender commented on code in PR #2835:
URL: https://github.com/apache/datafusion-comet/pull/2835#discussion_r2641717113
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -652,54 +678,61 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(gen.generateStrings(dataSize, numericPattern, 8).toDF("a"),
DataTypes.LongType)
}
- ignore("cast StringType to FloatType") {
- // https://github.com/apache/datafusion-comet/issues/326
- castTest(gen.generateStrings(dataSize, numericPattern, 8).toDF("a"),
DataTypes.FloatType)
- }
-
- test("cast StringType to FloatType (partial support)") {
- withSQLConf(
- CometConf.getExprAllowIncompatConfigKey(classOf[Cast]) -> "true",
- SQLConf.ANSI_ENABLED.key -> "false") {
- castTest(
- gen.generateStrings(dataSize, "0123456789.", 8).toDF("a"),
- DataTypes.FloatType,
- testAnsi = false)
+ test("cast StringType to FloatType special values") {
+ // TODO fix for Spark 4.0.0
+ assume(!isSpark40Plus)
+ Seq(true, false).foreach { v =>
+ castTest(specialValues.toDF("a"), DataTypes.FloatType, testAnsi = v)
}
}
- ignore("cast StringType to DoubleType") {
- // https://github.com/apache/datafusion-comet/issues/326
- castTest(gen.generateStrings(dataSize, numericPattern, 8).toDF("a"),
DataTypes.DoubleType)
+ test("cast StringType to DoubleType special values") {
+ // TODO fix for Spark 4.0.0
+ assume(!isSpark40Plus)
+ Seq(true, false).foreach { v =>
+ castTest(specialValues.toDF("a"), DataTypes.DoubleType, testAnsi = v)
+ }
}
- test("cast StringType to DoubleType (partial support)") {
- withSQLConf(
- CometConf.getExprAllowIncompatConfigKey(classOf[Cast]) -> "true",
- SQLConf.ANSI_ENABLED.key -> "false") {
+ test("cast StringType to DoubleType") {
+ // TODO fix for Spark 4.0.0
+ assume(!isSpark40Plus)
+ Seq(true, false).foreach { v =>
castTest(
- gen.generateStrings(dataSize, "0123456789.", 8).toDF("a"),
+ gen.generateStrings(dataSize, numericPattern, 10).toDF("a"),
DataTypes.DoubleType,
- testAnsi = false)
+ testAnsi = v)
}
}
- ignore("cast StringType to DecimalType(10,2)") {
- // https://github.com/apache/datafusion-comet/issues/325
- val values = gen.generateStrings(dataSize, numericPattern, 8).toDF("a")
- castTest(values, DataTypes.createDecimalType(10, 2))
+ test("cast StringType to FloatType") {
+ // TODO fix for Spark 4.0.0
+ assume(!isSpark40Plus)
+ Seq(true, false).foreach { v =>
+ castTest(
+ gen.generateStrings(dataSize, numericPattern, 10).toDF("a"),
+ DataTypes.FloatType,
+ testAnsi = v)
+ }
}
- test("cast StringType to DecimalType(10,2) (partial support)") {
- withSQLConf(
- CometConf.getExprAllowIncompatConfigKey(classOf[Cast]) -> "true",
- SQLConf.ANSI_ENABLED.key -> "false") {
- val values = gen
- .generateStrings(dataSize, "0123456789.", 8)
- .filter(_.exists(_.isDigit))
- .toDF("a")
- castTest(values, DataTypes.createDecimalType(10, 2), testAnsi = false)
- }
Review Comment:
Thank you for noticing it. These changes got removed while separating float
and decimal casts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
