andygrove commented on code in PR #2835:
URL: https://github.com/apache/datafusion-comet/pull/2835#discussion_r2643854517
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -1190,11 +1262,13 @@ fn is_datafusion_spark_compatible(
| DataType::Decimal256(_, _)
| DataType::Utf8 // note that there can be formatting
differences
),
- DataType::Utf8 if allow_incompat => matches!(
+ DataType::Utf8 if allow_incompat => {
+ matches!(to_type, DataType::Binary | DataType::Decimal128(_, _))
Review Comment:
I don't think `Decimal128` should be added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
