adriangb commented on PR #19426: URL: https://github.com/apache/datafusion/pull/19426#issuecomment-3688371359
> > I guess what I'm getting at, is maybe we should remove the `simplify` implementations entirely and rely only on `invoke`, and assume the `invoke` will get evaluated during optimization, meaning theres only a single place to check this new config. > > As far as I can tell `invoke_with_args` doesn't get the current execution time. Any thoughts as to how we'd pipe that in? I think we'd have to go all the way to updating `PhysicalExpr::evaluate` to from taking `RecordBatch` to `EvaluateArgs` which would then contain this runtime info, so then `ScalarFunctionExpr` can pipe it into `invoke_with_args` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
