Brijesh-Thakkar commented on PR #2988: URL: https://github.com/apache/datafusion-comet/pull/2988#issuecomment-3693316004
@coderfender I see the trim functions are registered in `comet_scalar_funcs.rs` (lines 183-198), but I couldn't find where they're actually implemented. That's why I created `trim.rs`. **My questions:** 1. Where is the current trim implementation that calls DataFusion's functions? 2. If it's already using DataFusion, what's causing the poor benchmark performance (0.6-0.7x)? 3. Should I be investigating something else instead? Could you point me to the right place to look? I want to make sure I'm fixing the actual bottleneck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
