Brijesh-Thakkar commented on PR #2988: URL: https://github.com/apache/datafusion-comet/pull/2988#issuecomment-3693322966
@coderfender Ah, I understand now! So the trim functions are implemented directly in DataFusion's codebase, not in Comet. So the right approach would be to: 1. Look at DataFusion's trim implementation 2. Identify the performance bottleneck there 3. Contribute the optimization to DataFusion upstream 4. Then Comet would benefit automatically That makes much more sense right?? Or what you think?? Like I should close this PR and look into the codebase of datafusion and try to solve this issue in that and then this issue will be solve automatically?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
