Jefffrey commented on PR #19475: URL: https://github.com/apache/datafusion/pull/19475#issuecomment-3695762743
> @Jefffrey thank you. Have you tried running any benchmarks? I’m curious whether there’s any performance improvement when calling it from Spark. ref. [apache/datafusion-comet#2986](https://github.com/apache/datafusion-comet/issues/2986) Performance wasn't on my mind when I did this refactor; I was more focused on trying to get the code in a more readable state. Adding fast paths for scalars should be trivial from this point on, but I'm not sure if I want to add more to this PR as is. Happy to do so if preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
