milenkovicm commented on code in PR #19437:
URL: https://github.com/apache/datafusion/pull/19437#discussion_r2650840361
##########
datafusion-examples/examples/proto/composed_extension_codec.rs:
##########
@@ -62,17 +63,19 @@ pub async fn composed_extension_codec() -> Result<()> {
Arc::new(ParentPhysicalExtensionCodec {}),
Arc::new(ChildPhysicalExtensionCodec {}),
]);
+ let proto_codec = DefaultPhysicalExtensionProtoCodec {};
Review Comment:
could we keep original methods which would create DPEPC{} internally to keep
backward compatibility and add new methods which would accept DPEPC as a
parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
