adriangb commented on code in PR #19437:
URL: https://github.com/apache/datafusion/pull/19437#discussion_r2651911765
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -3418,6 +3721,44 @@ struct DataEncoderTuple {
pub blob: Vec<u8>,
}
+pub struct DefaultPhysicalExtensionProtoCodec;
+impl PhysicalExtensionProtoCodec for DefaultPhysicalExtensionProtoCodec {
+ fn proto_to_execution_plan(
+ &self,
+ ctx: &TaskContext,
+ extension_codec: &dyn PhysicalExtensionCodec,
+ proto: &protobuf::PhysicalPlanNode,
+ ) -> Result<Arc<dyn ExecutionPlan>> {
+ proto.try_into_physical_plan(ctx, extension_codec, self)
+ }
+
+ // TODO(tsaucer) original variant had these as &mut self instead of &self
Review Comment:
I think `&self` is fine - we can always use interior mutability if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
