ntjohnson1 commented on issue #1305: URL: https://github.com/apache/datafusion-python/issues/1305#issuecomment-3696673215
From an end result perspective I prefer the coalesce direction. I think `resolve_duplicates` might be a nicer keyword. With my user hat on I don't care too much about HOW that happens under the hood so maybe this also makes things more flexible if we change later. Additionally, special caseing kwargs to not manage certain situations adds complexity. I think if the user wants to decide the details of how things are handled they can opt out of `resolve_duplicates`. I just opened a PR for datafusion to try and make resolving ambiguous column dropping and reference clearer so they can actually do so without just doing it in SQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
