adriangb commented on code in PR #19546:
URL: https://github.com/apache/datafusion/pull/19546#discussion_r2651237534
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -3512,3 +3512,97 @@ async fn
test_hashjoin_hash_table_pushdown_integer_keys() {
",
);
}
+
+#[tokio::test]
+async fn test_hashjoin_dynamic_filter_pushdown_not_used() {
Review Comment:
Is the output / result of this test different before / after this PR? Or
would the result be the same as long as `.with_support(false) // probe side
does not support dynamic filtering`? I'm okay merging this with only unit tests
if it's hard to see the change in action from an integration test, but I think
we should be clear about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
