LiaCastaneda commented on code in PR #19546:
URL: https://github.com/apache/datafusion/pull/19546#discussion_r2651386651
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -4610,6 +4635,11 @@ mod tests {
let dynamic_filter = HashJoinExec::create_dynamic_filter(&on);
let dynamic_filter_clone = Arc::clone(&dynamic_filter);
+ // Simulate a consumer by creating a transformed copy (what happens
during filter pushdown)
+ let _consumer = Arc::clone(&dynamic_filter)
+ .with_new_children(vec![])
+ .unwrap();
Review Comment:
I had to add a consumer in these tests, otherwise `is_used` will return
false, no filters will be computed and `wait_complete` will never return. I
will add an is_used check inside wait_complete as well, I can't imagine this
ever happenning (unless we call `wait_complete` on a probe node that does not
accept dynamic filters which would be wrong usage) but its worth adding just in
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
