alamb commented on PR #19462: URL: https://github.com/apache/datafusion/pull/19462#issuecomment-3699324177
> This requires to re-compute plans properties, as for many plans the method with_new_children uses Self::try_new to build a new plan. For example, FilterExec, AggregateExec, ProjectionExec. So, on each iteration we re-build the whole tree. I wonder if you have considered trying to optimize the re-creation of the plan (e.g optimizing with_new_children for the relevant nodes to avoid recomputing properties when the children have the same properties) In general I would really love to help make DataFusion planning (much) faster -- I think we have all the pieces now, but it will take some focused profiling effort to knock down the things that consume time to plan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
