ishan0308 commented on issue #17375: URL: https://github.com/apache/datafusion/issues/17375#issuecomment-3699891481
Hi @findepi I'm implementing this issue and have a question about public API functions. After removing `From<String> for Column`, public API functions like `col()`, `out_ref_col()`, and `unnest_column()` can no longer accept strings via `impl Into<Column>` [here](https://github.com/apache/datafusion/blob/main/datafusion/expr/src/expr_fn.rs#L76). I have 2 options - Change signatures to `impl Into<String>`, internally call `from_qualified_name()` (16 test fixes) - Keep `impl Into<Column>`, require explicit conversion at ~600 call sites Which approach is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
