Copilot commented on code in PR #19596:
URL: https://github.com/apache/datafusion/pull/19596#discussion_r2656645941
##########
datafusion/datasource/src/mod.rs:
##########
@@ -133,6 +134,8 @@ pub struct PartitionedFile {
/// When set via [`Self::with_statistics`], partition column statistics
are automatically
/// computed from [`Self::partition_values`] with exact
min/max/null_count/distinct_count.
pub statistics: Option<Arc<Statistics>>,
+ /// A known ordering of the data in this file.
Review Comment:
The documentation for the `ordering` field could be more descriptive.
Consider expanding it to match the detail provided in the `with_ordering`
method documentation, explaining that it represents the lexicographical sort
order of the data and is typically inferred from file metadata (e.g., Parquet
sorting_columns).
```suggestion
/// The known lexicographical ordering of the rows in this file, if any.
///
/// This describes how the data within the file is sorted with respect
to one or more
/// columns, and is used by the optimizer for planning operations that
depend on input
/// ordering (e.g. merges, sorts, and certain aggregations).
///
/// When available, this is typically inferred from file-level metadata
exposed by the
/// underlying format (for example, Parquet `sorting_columns`), but it
may also be set
/// explicitly via [`Self::with_ordering`].
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
