adriangb commented on code in PR #19599:
URL: https://github.com/apache/datafusion/pull/19599#discussion_r2658407424
##########
datafusion/common/src/stats.rs:
##########
@@ -321,6 +321,13 @@ impl Statistics {
}
}
+ /// Returns the memory size in bytes.
+ pub fn heap_size(&self) -> usize {
+ // column_statistics + num_rows + total_byte_size
+ self.column_statistics.capacity() * size_of::<ColumnStatistics>()
Review Comment:
Ah makes sense then as the choice if we’re going to use an external crate.
It seems like the most ergonomic. This does seems like something that should be
more of a community wide decision than isolated in this PR though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
