Jefffrey commented on code in PR #19547:
URL: https://github.com/apache/datafusion/pull/19547#discussion_r2658768935
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -206,7 +207,11 @@ impl ScalarUDFImpl for ConcatFunc {
DataType::Utf8View => {
let string_array = as_string_view_array(array)?;
- data_size += string_array.len();
+ data_size += string_array
+ .data_buffers()
+ .iter()
+ .map(|buf| buf.len())
+ .sum::<usize>();
Review Comment:
I don't think there is too noticeable iteration overhead if iterating over
`data_buffers` as I imagine most view arrays wouldn't have _that_ many data
buffers; I was more referring to iterating over the views themselves to grab
the lengths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
