milenkovicm commented on code in PR #1360:
URL:
https://github.com/apache/datafusion-ballista/pull/1360#discussion_r2661979782
##########
ballista/scheduler/Cargo.toml:
##########
@@ -52,6 +53,7 @@ clap = { workspace = true, optional = true }
dashmap = { workspace = true }
datafusion = { workspace = true }
datafusion-proto = { workspace = true }
+datafusion-substrait = { workspace = true, optional = true }
Review Comment:
Build fails at `protobuf-src v2.1.1+27.1` which comes from
https://github.com/substrait-io/substrait-rs/blob/f097b314fb9726866abd61a9935e48aeac68817e/Cargo.toml#L32
where proto feature should not be enabled. I wonder
https://github.com/apache/datafusion/blob/fd35a09438a2b4841431f5e86ffef378cbbda7c9/datafusion/substrait/Cargo.toml#L68
is triggering issue.
I wonder if `--no-default-features` for that specific dependency will make
any difference ?
I had a look at datafusion, they do install `cmake `for that specific target
(which should not be default)
As the last resort we could add `cmake` not sure if it will break windows
build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
