mattcuento commented on code in PR #1360:
URL:
https://github.com/apache/datafusion-ballista/pull/1360#discussion_r2662024965
##########
Cargo.toml:
##########
@@ -39,6 +39,7 @@ datafusion = "51.0.0"
datafusion-cli = "51.0.0"
datafusion-proto = "51.0.0"
datafusion-proto-common = "51.0.0"
+datafusion-substrait = { version = "51.0.0", features = ["protoc"] }
Review Comment:
Done, without this we should be back to a state where only the docker build
fails. From local:
```
Compiling substrait v0.62.2
error: failed to run custom build command for `substrait v0.62.2`
note: To improve backtraces for build dependencies, set the
CARGO_PROFILE_RELEASE_BUILD_OVERRIDE_DEBUG=true environment variable to enable
debug information generation.
Caused by:
process didn't exit successfully:
`/home/builder/workspace/target/release/build/substrait-2824a6349ada2508/build-script-build`
(exit status: 1)
--- stdout
cargo:rerun-if-env-changed=FORCE_REBUILD
cargo:rerun-if-changed=substrait
cargo:rerun-if-changed=substrait/text/simple_extensions_schema.yaml
cargo:rerun-if-changed=substrait/text/dialect_schema.yaml
cargo:rerun-if-changed=substrait/proto/substrait/algebra.proto
cargo:rerun-if-changed=substrait/proto/substrait/plan.proto
cargo:rerun-if-changed=substrait/proto/substrait/type_expressions.proto
cargo:rerun-if-changed=substrait/proto/substrait/parameterized_types.proto
cargo:rerun-if-changed=substrait/proto/substrait/capabilities.proto
cargo:rerun-if-changed=substrait/proto/substrait/type.proto
cargo:rerun-if-changed=substrait/proto/substrait/function.proto
cargo:rerun-if-changed=substrait/proto/substrait/extensions/extensions.proto
cargo:rerun-if-changed=substrait/proto/substrait/extended_expression.proto
--- stderr
Error: Custom { kind: Other, error: "protoc failed:
substrait/algebra.proto: This file contains proto3 optional fields, but
--experimental_allow_proto3_optional was not set.\n" }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
