mbutrovich commented on code in PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#discussion_r2665268182
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -145,21 +145,9 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] with Com
if (!CometScanExec.isFileFormatSupported(r.fileFormat)) {
return withInfo(scanExec, s"Unsupported file format ${r.fileFormat}")
}
+ val hadoopConf =
r.sparkSession.sessionState.newHadoopConfWithOptions(r.options)
- var scanImpl = COMET_NATIVE_SCAN_IMPL.get()
-
- val hadoopConf = scanExec.relation.sparkSession.sessionState
- .newHadoopConfWithOptions(scanExec.relation.options)
-
- // if scan is auto then pick the best available scan
- if (scanImpl == SCAN_AUTO) {
- scanImpl = selectScan(scanExec, r.partitionSchema, hadoopConf)
- }
-
- if (scanImpl == SCAN_NATIVE_DATAFUSION &&
!CometNativeScan.isSupported(scanExec)) {
- return scanExec
- }
-
+ // TODO is this restriction valid for all native scan types?
Review Comment:
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
