killzoner commented on code in PR #1374:
URL:
https://github.com/apache/datafusion-ballista/pull/1374#discussion_r2676166159
##########
ballista/client/src/extension.rs:
##########
@@ -93,7 +93,7 @@ impl SessionContextExt for SessionContext {
async fn remote_with_state(
url: &str,
state: SessionState,
- ) -> datafusion::error::Result<SessionContext> {
+ ) -> datafusion::error::Result<Self> {
Review Comment:
changed to `Self` for consistency, can also change to `SessionContext` (I
don't have an strong opinion)
##########
ballista/client/src/extension.rs:
##########
@@ -93,7 +93,7 @@ impl SessionContextExt for SessionContext {
async fn remote_with_state(
url: &str,
state: SessionState,
- ) -> datafusion::error::Result<SessionContext> {
+ ) -> datafusion::error::Result<Self> {
Review Comment:
changed to `Self` for consistency, can also change to `SessionContext` (I
don't have a strong opinion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
