milenkovicm commented on code in PR #1374:
URL: 
https://github.com/apache/datafusion-ballista/pull/1374#discussion_r2684037762


##########
ballista/core/src/execution_plans/shuffle_reader.rs:
##########
@@ -390,6 +393,7 @@ fn send_fetch_partitions(
     max_message_size: usize,
     force_remote_read: bool,
     flight_transport: bool,
+    arrow_ipc_reader_skip_validation: bool,

Review Comment:
   Can we not have it as parameter ?



##########
ballista/core/src/config.rs:
##########
@@ -212,6 +222,19 @@ impl BallistaConfig {
         &self.settings
     }
 
+    /// Allows skipping redundant validation of arrow IPC valid data.

Review Comment:
   Can we move this to shuffle reader, not sure if it makes sense to keep it in 
config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to