alamb opened a new issue, #19749: URL: https://github.com/apache/datafusion/issues/19749
You can probably use https://doc.rust-lang.org/std/primitive.str.html#method.char_indices here to avoid copying the strings into `chars_buf` entirely -- you could just find the correct offset and then copy the relevant bytes If you wanted to get super fancy, you could add specializations for: 1. Scalar `n` (no need to expand it out to an array) 2. StringViewArray (no need to copy strings at all, you could just adjust the views) However, this code seems better than what is on main! So we can merge it too and keep iterating _Originally posted by @alamb in https://github.com/apache/datafusion/pull/19571#discussion_r2677488816_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
