alamb commented on code in PR #19355:
URL: https://github.com/apache/datafusion/pull/19355#discussion_r2678618793
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -8868,7 +8868,7 @@ mod tests {
.unwrap(),
ScalarValue::try_new_null(&DataType::Map(map_field_ref,
false)).unwrap(),
ScalarValue::try_new_null(&DataType::Union(
- UnionFields::new(vec![42], vec![field_ref]),
+ UnionFields::try_new(vec![42], vec![field_ref]).unwrap(),
Review Comment:
Changes due to this one from @friendlymatthew
- https://github.com/apache/arrow-rs/pull/8891
##########
datafusion/sqllogictest/test_files/spark/hash/crc32.slt:
##########
@@ -81,7 +81,7 @@ SELECT crc32(arrow_cast('Spark', 'BinaryView'));
----
1557323817
-# Upstream arrow-rs issue: https://github.com/apache/arrow-rs/issues/8841
-# This should succeed after we receive the fix
-query error Arrow error: Compute error: Internal Error: Cannot cast BinaryView
to BinaryArray of expected type
+query I
Review Comment:
I updated the PR description to close #19290 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
