cht42 commented on code in PR #19805:
URL: https://github.com/apache/datafusion/pull/19805#discussion_r2689876556
##########
datafusion/spark/benches/substring.rs:
##########
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Here are the spark results
```
Gnuplot not found, using plotters backend
SHORTER THAN 12/substr_string_view [size=1024, strlen=12]
time: [9.9232 µs 10.026 µs 10.152 µs]
change: [−7.1598% −4.5501% −1.9410%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
SHORTER THAN 12/substr_string [size=1024, strlen=12]
time: [7.6418 µs 7.7211 µs 7.8093 µs]
change: [−5.7939% −4.3511% −2.9604%] (p = 0.00 <
0.05)
Performance has improved.
SHORTER THAN 12/substr_large_string [size=1024, strlen=12]
time: [8.1936 µs 8.2795 µs 8.3950 µs]
change: [−1.0788% +1.1240% +3.2863%] (p = 0.35 >
0.05)
No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
LONGER THAN 12/substr_string_view [size=1024, count=64, strlen=128]
time: [14.973 µs 15.169 µs 15.429 µs]
change: [−7.8723% −6.2097% −4.5124%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 10 measurements (40.00%)
2 (20.00%) low mild
2 (20.00%) high severe
LONGER THAN 12/substr_string [size=1024, count=64, strlen=128]
time: [12.132 µs 12.183 µs 12.233 µs]
change: [−2.6108% −1.7885% −0.9863%] (p = 0.00 <
0.05)
Change within noise threshold.
LONGER THAN 12/substr_large_string [size=1024, count=64, strlen=128]
time: [12.259 µs 12.317 µs 12.379 µs]
change: [−0.6746% +0.5829% +1.5354%] (p = 0.36 >
0.05)
No change in performance detected.
SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=1024, count=6,
strlen=128]
time: [22.497 µs 22.631 µs 22.793 µs]
change: [+14.141% +15.106% +16.196%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
SRC_LEN > 12, SUB_LEN < 12/substr_string [size=1024, count=6, strlen=128]
time: [20.755 µs 20.850 µs 20.978 µs]
change: [+11.588% +12.530% +13.505%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=1024, count=6,
strlen=128]
time: [20.794 µs 21.045 µs 21.459 µs]
change: [+12.461% +14.587% +17.165%] (p = 0.00 <
0.05)
Performance has regressed.
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high severe
SHORTER THAN 12/substr_string_view [size=4096, strlen=12]
time: [38.334 µs 38.569 µs 38.934 µs]
change: [−3.5892% −2.4961% −1.3414%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
SHORTER THAN 12/substr_string [size=4096, strlen=12]
time: [27.456 µs 27.548 µs 27.640 µs]
change: [−7.7751% −6.4787% −5.1817%] (p = 0.00 <
0.05)
Performance has improved.
SHORTER THAN 12/substr_large_string [size=4096, strlen=12]
time: [30.323 µs 30.777 µs 31.286 µs]
change: [+0.5779% +2.5736% +4.5147%] (p = 0.03 <
0.05)
Change within noise threshold.
LONGER THAN 12/substr_string_view [size=4096, count=64, strlen=128]
time: [55.663 µs 56.315 µs 57.106 µs]
change: [−5.8614% −4.2864% −2.6591%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
LONGER THAN 12/substr_string [size=4096, count=64, strlen=128]
time: [40.263 µs 40.768 µs 41.399 µs]
change: [−1.1384% +0.2204% +1.8436%] (p = 0.81 >
0.05)
No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
1 (10.00%) high mild
1 (10.00%) high severe
LONGER THAN 12/substr_large_string [size=4096, count=64, strlen=128]
time: [43.083 µs 43.261 µs 43.452 µs]
change: [−1.0141% +0.3950% +1.6334%] (p = 0.60 >
0.05)
No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high mild
SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=4096, count=6,
strlen=128]
time: [84.649 µs 85.064 µs 85.500 µs]
change: [+13.219% +13.958% +14.695%] (p = 0.00 <
0.05)
Performance has regressed.
SRC_LEN > 12, SUB_LEN < 12/substr_string [size=4096, count=6, strlen=128]
time: [76.146 µs 77.393 µs 79.422 µs]
change: [+9.5938% +11.574% +14.516%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=4096, count=6,
strlen=128]
time: [76.974 µs 77.166 µs 77.365 µs]
change: [+10.387% +10.783% +11.192%] (p = 0.00 <
0.05)
Performance has regressed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
