cht42 commented on code in PR #19805: URL: https://github.com/apache/datafusion/pull/19805#discussion_r2693002124
########## datafusion/spark/src/function/string/mod.rs: ########## @@ -40,6 +41,8 @@ make_udf_function!(like::SparkLike, like); make_udf_function!(luhn_check::SparkLuhnCheck, luhn_check); make_udf_function!(format_string::FormatStringFunc, format_string); make_udf_function!(space::SparkSpace, space); +make_udf_function!(substring::SparkSubstring, substring); +make_udf_function!(substring::SparkSubstring, substr); Review Comment: thats when I was debugging why the SLT tests kept falling back to the other implementation 😅 when I realized that I needed the custom expr planner it fixed things. will remove the dup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
