kosiew commented on code in PR #19719:
URL: https://github.com/apache/datafusion/pull/19719#discussion_r2689278256
##########
datafusion/catalog/src/streaming.rs:
##########
@@ -105,7 +104,18 @@ impl TableProvider for StreamingTable {
let df_schema = DFSchema::try_from(Arc::clone(&self.schema))?;
let eqp = state.execution_props();
- create_physical_sort_exprs(&self.sort_order, &df_schema, eqp)?
+ let original_sort_exprs =
+ create_physical_sort_exprs(&self.sort_order, &df_schema, eqp)?;
+
+ if let Some(p) = projection {
+ let schema = Arc::new(self.schema.project(p)?);
+ LexOrdering::new(original_sort_exprs)
+ .and_then(|lex_ordering| project_ordering(&lex_ordering,
&schema))
+ .map(|lex_ordering| lex_ordering.to_vec())
+ .unwrap_or_default()
Review Comment:
A comment explaining the projection adjustment will be helpful here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
