feniljain commented on issue #19654: URL: https://github.com/apache/datafusion/issues/19654#issuecomment-3753063148
>So the point being that offset and limit only really make sense when there is an ORDER BY clause attached too Yup, this was the insight which led me to ask above. Thanks for the clarification! Also, I realized something interesting. I was trying out a few queries, and it seems we don't have proper `limit` support too? Just to be sure I logged all the files read, we are reading all of them in both cases. ```sh > select avg(ss_sold_time_sk) from '/Users/feniljain/app/dataset/tpcds_1_delta/store_sales'; +-----------------------------------------------------------------------------+ | avg(/Users/feniljain/app/dataset/tpcds_1_delta/store_sales.ss_sold_time_sk) | +-----------------------------------------------------------------------------+ | 51704.80870499884 | +-----------------------------------------------------------------------------+ 1 row(s) fetched. Elapsed 1.273 seconds. > select avg(ss_sold_time_sk) from '/Users/feniljain/app/dataset/tpcds_1_delta/store_sales' limit 10; +-----------------------------------------------------------------------------+ | avg(/Users/feniljain/app/dataset/tpcds_1_delta/store_sales.ss_sold_time_sk) | +-----------------------------------------------------------------------------+ | 51704.80870499884 | +-----------------------------------------------------------------------------+ 1 row(s) fetched. Elapsed 0.849 seconds. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
