cj-zhukov commented on PR #19750: URL: https://github.com/apache/datafusion/pull/19750#issuecomment-3762808976
@Jefffrey Thanks for the review and for raising these points - they’re all fair concerns. I agree this is pushing Bash beyond simple glue logic. I started there to avoid introducing new dependencies and to stay consistent with existing CI scripts, but if the overall approach makes sense, I’d be happy to follow up with a Rust or Python implementation to improve maintainability. Regarding `examples.toml`: I also don’t love having a separate metadata file, but I couldn’t find a reliable single source of truth for example subcommands and descriptions. Parsing Rust source felt more brittle, and unlike function docs, examples aren’t exposed via a library API that we can introspect. The capitalization issues you noticed (e.g. SQL / IO) are artifacts of the current heuristics and can be fixed - either via normalization or explicit metadata. I’m definitely open to alternative ideas here and would love more input if others have suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
