GaneshPatil7517 commented on PR #19863: URL: https://github.com/apache/datafusion/pull/19863#issuecomment-3764880603
Thanks for the feedback @Jefffrey! I've simplified the approach significantly: Changes made: ✅ Switched to rust:1.92.0-bookworm base image (install Python on top instead of vice versa) ✅ Removed [docker-compose.yml](vscode-file://vscode-app/c:/Users/HP/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/workbench/workbench.html) - overkill for this use case ✅ Removed entrypoint.sh and CRLF conversion logic - users should configure git properly ✅ Removed COPY . /work - use volume mount at runtime instead ✅ Removed unnecessary comments Usage is now simply: docker build -t datafusion-docs ./docs docker run --rm -v $(pwd):/datafusion datafusion-docs Tested locally and the docs build successfully. Please take another look!> docker build -t datafusion-docs ./docs docker run --rm -v $(pwd):/datafusion datafusion-docs Tested locally and the docs build successfully. Please take another look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
