GaneshPatil7517 commented on code in PR #19863: URL: https://github.com/apache/datafusion/pull/19863#discussion_r2704105290
########## docs/README.md: ########## @@ -25,11 +25,31 @@ https://datafusion.apache.org/ as part of the release process. ## Dependencies +### Option 1: Docker (Recommended) + +If you have Docker installed, you can build the docs without installing any dependencies on your system: + +```sh +# Using docker-compose (simplest) (POSIX shells: bash, zsh, etc.) +docker-compose run --rm docs bash build.sh + +# Or using docker directly (POSIX shells: bash, zsh, etc.) +docker build -t datafusion-docs -f docs/Dockerfile . +docker run --rm -v $(pwd):/work datafusion-docs bash build.sh +# On Windows PowerShell, use: +# docker run --rm -v ${PWD}:/work datafusion-docs bash build.sh +``` Review Comment: Good catch! Fixed the README commands to match the simplified Dockerfile: # Build the Docker image (from repository root) docker build -t datafusion-docs ./docs # Run the docs build docker run --rm -v $(pwd):/datafusion datafusion-docs Removed references to docker-compose and updated the mount path.> # Build the Docker image (from repository root) docker build -t datafusion-docs ./docs Run the docs build docker run --rm -v $(pwd):/datafusion datafusion-docs Removed references to docker-compose and updated the mount path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
