alamb commented on code in PR #19819: URL: https://github.com/apache/datafusion/pull/19819#discussion_r2702576888
########## datafusion/sqllogictest/test_files/encoding.slt: ########## @@ -55,10 +55,10 @@ CREATE TABLE test( ; # errors -query error DataFusion error: Error during planning: Internal error: Expect TypeSignatureClass::Binary but received NativeType::Int64, DataType: Int64 Review Comment: 👍 for a planning error rather than internal error ########## datafusion/sqllogictest/test_files/datetime/timestamps.slt: ########## @@ -3337,7 +3337,7 @@ select make_time(22, '', 27); query error Cannot cast string '' to value of Int32 type select make_time(22, 1, ''); -query error Expect TypeSignatureClass::Native\(LogicalType\(Native\(Int32\), Int32\)\) but received NativeType::Float64, DataType: Float64 +query error DataFusion error: Error during planning: Function 'make_time' requires TypeSignatureClass::Native\(LogicalType\(Native\(Int32\), Int32\)\), but received Float64 \(DataType: Float64\) Review Comment: I think these messages are much nicer -- thank you @lemorage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
