ethan-tyler commented on PR #1337:
URL: 
https://github.com/apache/datafusion-python/pull/1337#issuecomment-3769953561

   > Cross posting for visibility @ethan-tyler I made a PR targeting your DF52 
branch [ethan-tyler/delta-rs#1](https://github.com/ethan-tyler/delta-rs/pull/1) 
but I see this morning you have a newer branch. I can port the changes over to 
it without much difficulty I think. I made a change today in how we call 
`__datafusion_table_provider__` to pass a PyCapsule that contains the 
`FFI_LogicalExtensionCodec` so that you can create your FFI table provider 
using it and not have to create and store a session context.
   
   Hey @timsaucer - thanks again for being so helpful (and patient) with the 
DF52 wheel testing. I really appreciate the time you’ve put into this.
   
   I'm still doing the testing on the delta-rs side, but a bit of context: I 
split the first PR into a minimal "get compiling + tests passing" extraction 
(delta-io/delta-rs#4092), that's the main DF52 upgrade for delta-rs. In the 
last day or so, direction from the maintainers has been to do some refactoring 
work separately, not part of the upgrade itself, but work that needs to happen 
to land the upgrade correctly (predicate planning, schema handling).
   
   It's adding time before I can give you clean, actionable results. I'll get 
the wheel testing done and report back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to