kosiew commented on code in PR #19674:
URL: https://github.com/apache/datafusion/pull/19674#discussion_r2707454634


##########
datafusion/common/src/nested_struct.rs:
##########
@@ -31,6 +31,7 @@ use std::sync::Arc;
 ///
 /// ## Field Matching Strategy
 /// - **By Name**: Source struct fields are matched to target fields by name 
(case-sensitive)
+/// - **By Position**: When there is no name overlap and the field counts 
match, fields are cast by index

Review Comment:
   I will remove [positional 
casting](https://github.com/apache/datafusion/issues/19841) after this PR.
   I actually did it on a local branch and reverted it because so that would be 
a stand-alone PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to