Dandandan commented on code in PR #19910:
URL: https://github.com/apache/datafusion/pull/19910#discussion_r2709008542
##########
datafusion/physical-expr-common/src/binary_map.rs:
##########
@@ -389,7 +389,7 @@ where
// is value is already present in the set?
let entry = self.map.find_mut(hash, |header| {
// compare value if hashes match
- if header.len != value_len {
+ if header.hash != hash {
Review Comment:
Comment says "compare value if hashes match" but actual implementation is
comparing lengths 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
