Dandandan commented on code in PR #19910:
URL: https://github.com/apache/datafusion/pull/19910#discussion_r2709015387
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -273,11 +273,10 @@ where
let value: &[u8] = value.as_ref();
let entry = self.map.find_mut(hash, |header| {
- let v = self.builder.get_value(header.view_idx);
-
- if v.len() != value.len() {
+ if header.hash != hash {
Review Comment:
This should save some random access if a lot of values share the same length
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
