alamb commented on code in PR #19727:
URL: https://github.com/apache/datafusion/pull/19727#discussion_r2712967026
##########
datafusion/functions-aggregate/src/variance.rs:
##########
@@ -561,9 +535,9 @@ impl GroupsAccumulator for VarianceGroupsAccumulator {
) -> Result<()> {
assert_eq!(values.len(), 3, "two arguments to merge_batch");
// first batch is counts, second is partial means, third is partial m2s
- let partial_counts = downcast_value!(values[0], UInt64Array);
Review Comment:
Yeah the biggest difference as I recall is taht ones in arrow panic, and the
ones in DataFusion retun errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
