adriangb commented on code in PR #19404:
URL: https://github.com/apache/datafusion/pull/19404#discussion_r2713785129
##########
datafusion/physical-plan/src/util.rs:
##########
@@ -0,0 +1,383 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Sorry to be annoying - one last request - could we rename this to
`column_rewriter.rs` to avoid a `util.rs` module that as of today only holds
one thing?
Here's the diff:
```
diff --git a/datafusion/physical-plan/src/util.rs
b/datafusion/physical-plan/src/column_rewriter.rs
similarity index 100%
rename from datafusion/physical-plan/src/util.rs
rename to datafusion/physical-plan/src/column_rewriter.rs
diff --git a/datafusion/physical-plan/src/lib.rs
b/datafusion/physical-plan/src/lib.rs
index 79c0e9ef5..9352a143c 100644
--- a/datafusion/physical-plan/src/lib.rs
+++ b/datafusion/physical-plan/src/lib.rs
@@ -68,6 +68,7 @@ pub mod async_func;
pub mod coalesce;
pub mod coalesce_batches;
pub mod coalesce_partitions;
+pub mod column_rewriter;
pub mod common;
pub mod coop;
pub mod display;
@@ -92,7 +93,6 @@ pub mod streaming;
pub mod tree_node;
pub mod union;
pub mod unnest;
-pub mod util;
pub mod windows;
pub mod work_table;
pub mod udaf {
diff --git a/datafusion/physical-plan/src/projection.rs
b/datafusion/physical-plan/src/projection.rs
index 1e9671900..8d4c775f8 100644
--- a/datafusion/physical-plan/src/projection.rs
+++ b/datafusion/physical-plan/src/projection.rs
@@ -26,13 +26,13 @@ use super::{
DisplayAs, ExecutionPlanProperties, PlanProperties, RecordBatchStream,
SendableRecordBatchStream, SortOrderPushdownResult, Statistics,
};
+use crate::column_rewriter::PhysicalColumnRewriter;
use crate::execution_plan::CardinalityEffect;
use crate::filter_pushdown::{
ChildFilterDescription, ChildPushdownResult, FilterColumnChecker,
FilterDescription,
FilterPushdownPhase, FilterPushdownPropagation, PushedDownPredicate,
};
use crate::joins::utils::{ColumnIndex, JoinFilter, JoinOn, JoinOnRef};
-use crate::util::PhysicalColumnRewriter;
use crate::{DisplayFormatType, ExecutionPlan, PhysicalExpr};
use std::any::Any;
use std::collections::HashMap;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
