milenkovicm commented on code in PR #1351: URL: https://github.com/apache/datafusion-ballista/pull/1351#discussion_r2714406356
########## ballista/scheduler/src/flight_proxy_service.rs: ########## @@ -0,0 +1,188 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow_flight::flight_service_client::FlightServiceClient; +use arrow_flight::flight_service_server::FlightService; +use arrow_flight::{ + Action, ActionType, Criteria, Empty, FlightData, FlightDescriptor, FlightInfo, + HandshakeRequest, HandshakeResponse, PollInfo, PutResult, SchemaResult, Ticket, +}; +use ballista_core::error::BallistaError; +use ballista_core::serde::decode_protobuf; +use ballista_core::serde::scheduler::Action as BallistaAction; +use ballista_core::utils::{GrpcClientConfig, create_grpc_client_connection}; + +use futures::{Stream, TryFutureExt}; +use log::debug; +use std::pin::Pin; +use tonic::{Request, Response, Status, Streaming}; + +/// Service implementing a proxy from scheduler to executor Apache Arrow Flight Protocol +/// +/// The proxy only implements the FlightService::do_get api and forwards the requests +/// to the respective executors. +/// +#[derive(Clone)] +pub struct BallistaFlightProxyService { + max_decoding_message_size: usize, + max_encoding_message_size: usize, +} + +impl BallistaFlightProxyService { + pub fn new( + max_decoding_message_size: usize, + max_encoding_message_size: usize, + ) -> Self { + Self { + max_decoding_message_size, + max_encoding_message_size, + } + } +} + +type BoxedFlightStream<T> = + Pin<Box<dyn Stream<Item = Result<T, Status>> + Send + 'static>>; + +#[tonic::async_trait] +impl FlightService for BallistaFlightProxyService { + type DoActionStream = BoxedFlightStream<arrow_flight::Result>; + type DoExchangeStream = BoxedFlightStream<FlightData>; + type DoGetStream = BoxedFlightStream<FlightData>; + type DoPutStream = BoxedFlightStream<PutResult>; + type HandshakeStream = BoxedFlightStream<HandshakeResponse>; + type ListActionsStream = BoxedFlightStream<ActionType>; + type ListFlightsStream = BoxedFlightStream<FlightInfo>; + async fn handshake( + &self, + _request: Request<Streaming<HandshakeRequest>>, + ) -> Result<Response<Self::HandshakeStream>, Status> { + Err(Status::unimplemented("handshake")) + } + + async fn list_flights( + &self, + _request: Request<Criteria>, + ) -> Result<Response<Self::ListFlightsStream>, Status> { + Err(Status::unimplemented("list_flights")) + } + + async fn get_flight_info( + &self, + _request: Request<FlightDescriptor>, + ) -> Result<Response<FlightInfo>, Status> { + Err(Status::unimplemented("get_flight_info")) + } + + async fn poll_flight_info( + &self, + _request: Request<FlightDescriptor>, + ) -> Result<Response<PollInfo>, Status> { + Err(Status::unimplemented("poll_flight_info")) + } + + async fn get_schema( + &self, + _request: Request<FlightDescriptor>, + ) -> Result<Response<SchemaResult>, Status> { + Err(Status::unimplemented("get_schema")) + } + + async fn do_get( + &self, + request: Request<Ticket>, + ) -> Result<Response<Self::DoGetStream>, Status> { + let ticket = request.into_inner(); + + let action = + decode_protobuf(&ticket.ticket).map_err(|e| from_ballista_err(&e))?; + + match &action { + BallistaAction::FetchPartition { + host, port, job_id, .. + } => { + debug!("Fetching results for job id: {job_id} from {host}:{port}"); + let mut client = get_flight_client( + host, + *port, + self.max_decoding_message_size, + self.max_encoding_message_size, + ) + .map_err(|e| from_ballista_err(&e)) + .await?; + client + .do_get(Request::new(ticket)) + .await + .map(|r| Response::new(Box::pin(r.into_inner()) as Self::DoGetStream)) + } + } + } + + async fn do_put( + &self, + _request: Request<Streaming<FlightData>>, + ) -> Result<Response<Self::DoPutStream>, Status> { + Err(Status::unimplemented("do_put")) + } + + async fn do_exchange( + &self, + _request: Request<Streaming<FlightData>>, + ) -> Result<Response<Self::DoExchangeStream>, Status> { + Err(Status::unimplemented("do_exchange")) + } + + async fn do_action( + &self, + _request: Request<Action>, + ) -> Result<Response<Self::DoActionStream>, Status> { + Err(Status::unimplemented("do_action")) + } + + async fn list_actions( + &self, + _request: Request<Empty>, + ) -> Result<Response<Self::ListActionsStream>, Status> { + Err(Status::unimplemented("list_actions")) + } +} + +fn from_ballista_err(e: &ballista_core::error::BallistaError) -> Status { + Status::internal(format!("Ballista Error: {e:?}")) +} + +async fn get_flight_client( + host: &str, + port: u16, + max_decoding_message_size: usize, + max_encoding_message_size: usize, +) -> Result<FlightServiceClient<tonic::transport::channel::Channel>, BallistaError> { + let addr = format!("http://{host}:{port}";); Review Comment: we should not assume `http` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
