andygrove opened a new pull request, #3240: URL: https://github.com/apache/datafusion-comet/pull/3240
## Summary - Add new `iceberg-public-api` Maven module containing dedicated unit tests for all `@IcebergApi` annotated classes - Ensure the public API contract with Apache Iceberg remains stable and tested - Fix `CometVector` constructor visibility (protected -> public) to match its `@IcebergApi` annotation > **Note:** This PR builds on #3237 which adds the `@IcebergApi` annotation. Please merge #3237 first. ## Test Coverage (169 tests) | Category | Tests | Description | |----------|-------|-------------| | API Verification | `IcebergApiVerificationTest` | Reflection-based verification of all @IcebergApi elements | | Parquet | `FileReaderApiTest`, `RowGroupReaderApiTest` | File and row group reading APIs | | Column Readers | `ColumnReaderApiTest`, `BatchReaderApiTest`, etc. | Column reader class hierarchies | | Native | `NativeApiTest` | JNI method signature verification | | Type Utils | `TypeUtilApiTest`, `UtilsApiTest` | Type conversion and utility methods | | Vector | `CometVectorApiTest` | Arrow vector wrapper APIs | | Schema | `CometSchemaImporterApiTest` | Schema import APIs | | Adapter | `WrappedInputFileApiTest` | InputFile wrapper for Iceberg | ## Test plan - [x] All 169 tests pass locally with `mvn test -DwildcardSuites="org.apache.comet.iceberg.api"` - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
