adriangb commented on code in PR #19538:
URL: https://github.com/apache/datafusion/pull/19538#discussion_r2721543142
##########
datafusion/expr/src/udf.rs:
##########
@@ -846,6 +858,32 @@ pub trait ScalarUDFImpl: Debug + DynEq + DynHash + Send +
Sync {
fn documentation(&self) -> Option<&Documentation> {
None
}
+
+ /// Returns the triviality classification of this function given its
arguments' triviality.
Review Comment:
Won't work for `PhysicalExpr` because of crate dependencies and even if it
did it would require implementers to handle the two types of expressions
independently (two methods, two match clauses, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
