Jefffrey commented on PR #19874: URL: https://github.com/apache/datafusion/pull/19874#issuecomment-3794636930
I'm having trouble understanding the rationale here; `log`, `power` and `round` at most have one decimal input, and only `round` preserves the decimal type whereas the others will return floats anyway. So all this handling for getting precision/scale of left/right inputs, adjusting the scale of the output decimal, seems unused? Also for `round` we have a PR relating to altering precision/scale: - https://github.com/apache/datafusion/pull/19926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
