Dandandan commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3796896104
> Thanks for reviewing the benchmarks! Great to hear the speedup is reproducible. > > Regarding the builder overhead optimization for other cases - would you like me to explore that in a follow-up PR, or should we address it in this one before merging? > > Let me know if there's anything else needed for approval! I think it would be better to avoid the extra 16 bytes by either * storing only the views just in the struct, removing the builder usage and updating the original view, we don't need any offset more, so we end up saving 8 bytes per value * remove the u128 view in the struct and keep the reference. I think in the builder interface we need to expose the views to be able to support this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
