Dandandan commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3797133548
> Option 1: Remove the builder usage entirely and store only the u128 views directly in the Entry struct, updating the original view in-place. This eliminates the offset field and saves 8 bytes per value. This probably seems to be the way forward, as the builder pattern will bet hard to optimize for and does not give the abstracrions we need here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
