Dandandan commented on PR #19975: URL: https://github.com/apache/datafusion/pull/19975#issuecomment-3798117379
> Benchmarks look good! The optimization shows improvements especially on clickbench: > > clickbench_extended: 3 queries faster, 0 slower clickbench_partitioned: 4 queries faster (Query 23 is 1.96x faster!), 2 minor regressions tpch: neutral Removed builder_idx from Entry and replaced GenericByteViewBuilder with direct buffer management as suggested. Some of those unfortunately are noise, but the clickbench_extended are real improvements! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
