Jefffrey commented on code in PR #19895:
URL: https://github.com/apache/datafusion/pull/19895#discussion_r2736735668
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -722,6 +729,15 @@ impl PartialOrd for ScalarValue {
if k1 == k2 { v1.partial_cmp(v2) } else { None }
}
(Dictionary(_, _), _) => None,
+ (RunEndEncoded(rf1, vf1, v1), RunEndEncoded(rf2, vf2, v2)) => {
+ // Don't compare if the run ends fields don't match (it is
effectively a different datatype)
Review Comment:
I'm not sure if we want that logic as this level; for example if we fix
`PartialOrd` here to compare REE/Dicts based on inner values only, then we'd
probably have to do the same for `PartialEq` right? But then we run into an
issue with `Hash` not being consistent unless we also fix `Hash` 🤔
I think it might be better to leave these as is, and if we want proper
comparison it would make more sense to do at a high level (e.g. via type
coercion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
