mattcuento commented on code in PR #1416:
URL:
https://github.com/apache/datafusion-ballista/pull/1416#discussion_r2737643368
##########
ballista/core/src/extension.rs:
##########
@@ -177,6 +203,9 @@ impl SessionStateExt for SessionState {
.with_query_planner(Arc::new(planner))
.build();
+ #[cfg(feature = "spark-compat")]
+ let session_state = register_spark_functions(session_state);
Review Comment:
Instead of needing to call `register_spark_functions` from wherever we build
state, I wonder if it'd be more elegant to push the registration of these
functions/the spark-compat feature upstream to the datafusion
`SessionStateBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
