randall commented on a change in pull request #6699: URL: https://github.com/apache/trafficserver/pull/6699#discussion_r420169114
########## File path: tests/gold_tests/tls/tls_client_cert2.test.py ########## @@ -170,3 +185,21 @@ trfail.Processes.Default.Command = 'curl -H host:random.foo.com http://127.0.0.1:{0}/case1'.format(ts.Variables.port) trfail.Processes.Default.ReturnCode = 0 trfail.Processes.Default.Streams.stdout = Testers.ContainsExpression("Could Not Connect", "Check response") + +# Parking this as a ready tester on a meaningless process +# Stall the test runs until the squid.log file has appeared +def access_log_ready(tsenv): Review comment: indentation is not a multiple of four ########## File path: tests/gold_tests/tls/tls_client_cert.test.py ########## @@ -293,3 +306,21 @@ def done_reload(process, hasRunFor, **kw): tr4fail.Processes.Default.Command = 'curl -H host:example.com http://127.0.0.1:{0}/case2'.format(ts.Variables.port) tr4fail.Processes.Default.ReturnCode = 0 tr4fail.Processes.Default.Streams.stdout = Testers.ContainsExpression("Could Not Connect", "Check response") + +# Parking this as a ready tester on a meaningless process +# Stall the test runs until the squid.log file has appeared +def access_log_ready(tsenv): + def done_access_log(process, hasRunFor, **kw): Review comment: indentation is not a multiple of four ########## File path: tests/gold_tests/tls/tls_client_verify.test.py ########## @@ -168,19 +184,39 @@ tr.Setup.Copy("ssl/server.key") tr.StillRunningAfter = ts tr.StillRunningAfter = server -tr.Processes.Default.Command = "curl --tls-max 1.2 -k --cert ./server.pem --key ./server.key --resolve 'bar.com:{0}:127.0.0.1' https://bar.com:{0}/case1".format(ts.Variables.ssl_port) +tr.Processes.Default.Command = "curl --tls-max 1.2 -k --cert ./server.pem --key ./server.key --resolve 'bar.com:{0}:127.0.0.1' https://bar.com:{0}/case12".format(ts.Variables.ssl_port) tr.Processes.Default.ReturnCode = 35 # Test that the fqdn's match completely. bob.com should require client certificate. bob.com.com should not tr = Test.AddTestRun("Connect to bob.com without cert, should fail") tr.StillRunningAfter = ts tr.StillRunningAfter = server -tr.Processes.Default.Command = "curl --tls-max 1.2 -k --resolve 'bob.com:{0}:127.0.0.1' https://bob.com:{0}/case1".format(ts.Variables.ssl_port) +tr.Processes.Default.Command = "curl --tls-max 1.2 -k --resolve 'bob.com:{0}:127.0.0.1' https://bob.com:{0}/case13".format(ts.Variables.ssl_port) tr.Processes.Default.ReturnCode = 35 tr = Test.AddTestRun("Connect to bob.com.com without cert, should succeed") tr.StillRunningAfter = ts tr.StillRunningAfter = server -tr.Processes.Default.Command = "curl --tls-max 1.2 -k --resolve 'bob.com.com:{0}:127.0.0.1' https://bob.com.com:{0}/case1".format(ts.Variables.ssl_port) +tr.Processes.Default.Command = "curl --tls-max 1.2 -k --resolve 'bob.com.com:{0}:127.0.0.1' https://bob.com.com:{0}/case14".format(ts.Variables.ssl_port) tr.Processes.Default.ReturnCode = 0 + +# Parking this as a ready tester on a meaningless process +# Stall the test runs until the squid.log file has appeared +def access_log_ready(tsenv): Review comment: indentation is not a multiple of four. also, can this be moved into a separate file for use in the 3 places that use it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
