zwoop commented on a change in pull request #6699:
URL: https://github.com/apache/trafficserver/pull/6699#discussion_r437689327
##########
File path: proxy/http/HttpSM.h
##########
@@ -523,25 +523,26 @@ class HttpSM : public Continuation, public
PluginUserArgs<TS_USER_ARGS_TXN>
public:
// TODO: Now that bodies can be empty, should the body counters be set to
-1 ? TS-2213
// Stats & Logging Info
- int client_request_hdr_bytes = 0;
- int64_t client_request_body_bytes = 0;
- int server_request_hdr_bytes = 0;
- int64_t server_request_body_bytes = 0;
- int server_response_hdr_bytes = 0;
- int64_t server_response_body_bytes = 0;
- int client_response_hdr_bytes = 0;
- int64_t client_response_body_bytes = 0;
- int cache_response_hdr_bytes = 0;
- int64_t cache_response_body_bytes = 0;
- int pushed_response_hdr_bytes = 0;
- int64_t pushed_response_body_bytes = 0;
- bool client_tcp_reused = false;
- bool client_ssl_reused = false;
- bool client_connection_is_ssl = false;
- bool is_internal = false;
- bool server_connection_is_ssl = false;
- bool is_waiting_for_full_body = false;
- bool is_using_post_buffer = false;
+ int client_request_hdr_bytes = 0;
+ int64_t client_request_body_bytes = 0;
+ int server_request_hdr_bytes = 0;
+ int64_t server_request_body_bytes = 0;
+ int server_response_hdr_bytes = 0;
+ int64_t server_response_body_bytes = 0;
+ int client_response_hdr_bytes = 0;
+ int64_t client_response_body_bytes = 0;
+ int cache_response_hdr_bytes = 0;
+ int64_t cache_response_body_bytes = 0;
+ int pushed_response_hdr_bytes = 0;
+ int64_t pushed_response_body_bytes = 0;
+ bool client_tcp_reused = false;
+ bool client_ssl_reused = false;
+ bool client_connection_is_ssl = false;
+ bool is_internal = false;
+ bool server_connection_is_ssl = false;
+ int server_connection_provided_cert = 0;
Review comment:
This likely introduces unnecessary padding. It'd be much better to move
the int member to be before, or after, all the other bool's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
