maskit commented on pull request #6925: URL: https://github.com/apache/trafficserver/pull/6925#issuecomment-646461299
The change is fine. I'd say release assert is too much, because callback functions may be able to fail safely if netvc is unavailable. I just thought "ensure" is not really accurate for the change. I'm not sure what it should be, but I'd say "Add an assert that checks availability of netvc". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
