sudheerv commented on pull request #6925: URL: https://github.com/apache/trafficserver/pull/6925#issuecomment-646729358
> The change is fine. I'd say release assert is too much, because callback functions may be able to fail safely if netvc is unavailable. > +1, Yeah I agree that netvc may be unavailable by the time the call back is invoked. In fact, the patch I'm running isn't this one. I've added guards against null netvc pointer and netvc <-> ssl reference in the call backs. I guess, that's why I used _ensure_ as the commit message, but, I agree it's not very accurate for the current patch. Let me update the patch and the message with what I've right now and may be hear what you think about that. > I just thought "ensure" is not really accurate for the change. I'm not sure what it should be, but I'd say "Add an assert that checks availability of netvc". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
